Skip to content

add T-Digest support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

add T-Digest support #25

merged 1 commit into from
May 11, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented May 9, 2021 •
edited by gkorland
Loading

fix #24

@codecov
Copy link

codecov bot commented May 9, 2021 •
edited
Loading

Codecov Report

Merging #25 (3626301) into master (849e48c) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   98.39%   98.65%   +0.26%     
==========================================
  Files           2        2              
  Lines         435      522      +87     
==========================================
+ Hits          428      515      +87     
  Misses          7        7
Impacted Files Coverage Δ
redisbloom/client.py 98.43% <100.00%> (+0.31%) ⬆️
test_commands.py 99.01% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849e48c...3626301. Read the comment docs.

@gkorland gkorland requested a review from filipecosta90 May 9, 2021 07:39
@gkorland gkorland linked an issue May 9, 2021 that may be closed by this pull request
Support for T-Digest data structure #24
Closed
filipecosta90
filipecosta90 requested changes May 11, 2021
View reviewed changes
Copy link

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvitalFineRedis With regards to the TDigest support it's flawless on the commands and test. great job!
Got only one comment with regards the mixing of formatting and features: can we removed the line changes about formating?

@filipecosta90
Copy link

@AvitalFineRedis With regards to the TDigest support it's flawless on the commands and test. great job!
Got only one comment with regards the mixing of formatting and features: can we removed the line changes about formating?

PS: please check #26 with regards a proposal of code formating ( that has always the same look and feel )

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@filipecosta90 filipecosta90 self-requested a review May 11, 2021 14:15
@AvitalFineRedis AvitalFineRedis merged commit d661bf8 into master May 11, 2021
@AvitalFineRedis AvitalFineRedis deleted the T-Digit branch May 11, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filipecosta90 filipecosta90 filipecosta90 approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for T-Digest data structure

2 participants

@AvitalFineRedis @filipecosta90